fix: remove error when main activity not found in AndroidManifest.xml

react-native-community · Nov 29, 2023 · c1080ad · c1080ad
1 parent ebde072
commit c1080ad
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/packages/cli-platform-android/src/config/getMainActivity.ts b/packages/cli-platform-android/src/config/getMainActivity.ts
@@ -21,7 +21,7 @@ interface IntentFilter {
  * Reads the AndroidManifest.xml file and returns the name of the main activity.
  */
 
-export default function getMainActivity(manifestPath: string): string | null {
+export default function getMainActivity(manifestPath: string): string {
   try {
     const xmlParser = new XMLParser({ignoreAttributes: false});
     const manifestContent = fs.readFileSync(manifestPath, {encoding: 'utf8'});
@@ -90,9 +90,9 @@ export default function getMainActivity(manifestPath: string): string | null {
 
       return mainActivity ? mainActivity['@_android:name'] : null;
     } else {
-      return null;
+      return '';
     }
   } catch {
-    return null;
+    return '';
   }
 }
diff --git a/packages/cli-platform-android/src/config/index.ts b/packages/cli-platform-android/src/config/index.ts
@@ -68,10 +68,6 @@ export function projectConfig(
     : packageName;
   const mainActivity = getMainActivity(manifestPath || '');
 
-  if (!mainActivity) {
-    throw new CLIError(`Main activity not found in ${manifestPath}`);
-  }
-
   return {
     sourceDir,
     appName,