ci: properly cache gradle #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by: #2148 |
szymonrybczak
force-pushed
the
ci/properly-cache-gradle
branch
from
bbc41bf to
a63a0c8
Compare
|
@szymonrybczak mind rebasing? |
szymonrybczak
force-pushed
the
ci/properly-cache-gradle
branch
from
a63a0c8 to
6b688b4
Compare
thymikee
approved these changes
Nov 2, 2023
adamTrz
approved these changes
Nov 3, 2023
cortinico
approved these changes
Nov 22, 2023
.github/workflows/test.yml
Outdated
| @@ -49,12 +49,17 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
|
|
|||
| - uses: actions/setup-java@v3 | |||
| with: | |||
| distribution: 'zulu' | |||
| java-version: 17 | |||
| cache: 'gradle' | |||
There was a problem hiding this comment.
you should remove this line if you use gradle/gradle-build-action
Comment on lines
+57
to
+63
| await spawnScript( | ||
| gradleWrapper, | ||
| ['wrapper', '--gradle-version=8.0.1', '--distribution-type', 'bin'], | ||
| { | ||
| cwd: androidProjectRoot, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
I don't think this is necessary 🤔 I've been using gradle/gradle-build-action with several projects which have the -all distribution and I haven't noticed re-downloads of Gradle.
There was a problem hiding this comment.
So I gave it a try and it is getting re-downloaded :( See here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Every time we're running
root.test.tsit downloads Gradle. In template there's specified Gradle's-alldistribution, but withgradle/gradle-build-actionwe can't specify it :( So we need to overwrite to-bin.Test Plan:
CI should cache Gradle version.
Checklist