fix(e2e): correctly link packages #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
commented
Nov 1, 2023
Comment on lines
-26
to
+30
| runCLI(cwd, ['init', 'TestProject', '--install-pods']); | ||
| runCLI(cwd, ['init', 'TestProject']); |
There was a problem hiding this comment.
Here we don't need to install pods, since this test check only android related things.
szymonrybczak
force-pushed
the
fix/correctly-link-pacakges
branch
from
4a3035b to
d2c9cc1
Compare
This was referenced Nov 1, 2023
Merged
|
Probably we should also properly delete cache before linking packages. Linked packages are stored under |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this PR I changed to link all packages before running testes. Recently there was introduced change to
initwhich createsreact-native.config.jswith some flag. But in tests we were only linkingcli-platform-androidandcli-platform-iosso creating project was failing since it installs Pods, and during installing Pods we calluse_native_moduleswhich executesconfigcommand that was outdated. And it was giving error:Test Plan:
CI Green
Checklist