npmPackageName should be resolved from project root, not from cli-plugin-metro #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
requested changes
Jul 4, 2023
|
Done. I also bumped deasync in the lock file, since the older version means |
thymikee
approved these changes
Jul 11, 2023
thymikee
pushed a commit
that referenced
this pull request
Jul 11, 2023
…gin-metro (#1996) * fix: npmPackageName should be resolved from project root, not from cli-plugin-metro * fix linting * Older deasync fails to yarn install on windows machines with newer visual studio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When resolving npmPackageName currently, we are resolving it from the cli-plugin-metro package. But cli-plugin-metro does not have a direct dependency on any of the out of tree platform packages (say react-native-windows or react-native-macos). Instead we should be resolving npmPackageName from the project root, which will have the out of tree package as a dependency.
This generally works today because so many package managers hoist everything and so packages can resolve other packages that are used in the repo even if they are not declared as dependencies. But some package managers are moving to be more strict about this.
Test Plan:
Checklist