Skip to content

Commit

Permalink
npmPackageName should be resolved from project root, not from cli-plu…
Browse files Browse the repository at this point in the history
…gin-metro (#1996)

* fix: npmPackageName should be resolved from project root, not from cli-plugin-metro

* fix linting

* Older deasync fails to yarn install on windows machines with newer visual studio
  • Loading branch information
acoates-ms authored Jul 11, 2023
1 parent 1e56ce7 commit 548e2bb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions packages/cli-plugin-metro/src/tools/loadMetroConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ function getOverrideConfig(ctx: ConfigLoadingContext): InputConfigT {
require.resolve(
`${ctx.platforms[platform]
.npmPackageName!}/Libraries/Core/InitializeCore`,
{paths: [ctx.root]},
),
),
],
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5301,9 +5301,9 @@ dayjs@^1.8.15:
integrity sha512-1kbWK0hziklUHkGgiKr7xm59KwAg/K3Tp7H/8X+f58DnNCwY3pKYjOCJpIlVs125FRBukGVZdKZojC073D0IeQ==

deasync@^0.1.14:
version "0.1.19"
resolved "https://registry.yarnpkg.com/deasync/-/deasync-0.1.19.tgz#e7ea89fcc9ad483367e8a48fe78f508ca86286e8"
integrity sha512-oh3MRktfnPlLysCPpBpKZZzb4cUC/p0aA3SyRGp15lN30juJBTo/CiD0d4fR+f1kBtUQoJj1NE9RPNWQ7BQ9Mg==
version "0.1.28"
resolved "https://registry.yarnpkg.com/deasync/-/deasync-0.1.28.tgz#9b447b79b3f822432f0ab6a8614c0062808b5ad2"
integrity sha512-QqLF6inIDwiATrfROIyQtwOQxjZuek13WRYZ7donU5wJPLoP67MnYxA6QtqdvdBy2mMqv5m3UefBVdJjvevOYg==
dependencies:
bindings "^1.5.0"
node-addon-api "^1.7.1"
Expand Down

0 comments on commit 548e2bb

Please sign in to comment.