Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing argument to xcodebuild shell (destination) for v8.x #1947

Closed
wants to merge 1 commit into from
Closed

fix: add missing argument to xcodebuild shell (destination) for v8.x #1947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/platform-ios/src/commands/runIOS/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ type FlagsT = {
verbose: boolean;
port: number;
terminal: string | undefined;
destination?: string;
};

function runIOS(_: Array<string>, ctx: Config, args: FlagsT) {
Expand Down Expand Up @@ -317,7 +318,7 @@ function buildProject(
'-scheme',
scheme,
'-destination',
`id=${udid}`,
`id=${udid}` + (args.destination ? ',' + args.destination : ''),
];
// @todo use `getLoader` from cli-tools package
const loader = ora();
Expand Down Expand Up @@ -604,6 +605,10 @@ export default {
description:
'Explicitly set device to use by name. The value is not required if you have a single device connected.',
},
{
name: '--destination <string>',
description: 'Explicitly extend distination e.g. "arch=x86_64"',
szymonrybczak marked this conversation as resolved.
Show resolved Hide resolved
},
{
name: '--udid <string>',
description: 'Explicitly set device to use by udid',
Expand Down