Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing argument to xcodebuild shell (destination) for v8.x #1947

Conversation

jtparrett
Copy link

@jtparrett jtparrett commented May 30, 2023

Summary:

This is a fix to allow the run-ios command to accept a destination arg so that rosetta devices can be used via the terminal build command on projects using v8 of the cli.

This is a v8 backport fix of this PR #1934

Please also read: #1918

@jtparrett jtparrett changed the title fix: add missing argument to xcodebuild shell (destination) fix: add missing argument to xcodebuild shell (destination) for v8.x May 30, 2023
@thymikee
Copy link
Member

thymikee commented May 31, 2023

It's gonna be weird if we had this in v8.x and not in 9 or 10. What's blocking you from upgrading to the latest React Native version?

@jtparrett
Copy link
Author

It's gonna be weird if we had this in v8.x and not in 9 or 10. What's blocking you from upgrading to the latest React Native version?

@thymikee We've not explored upgrading RN it in detail, but we're on RN 0.69 so I suspect there would be node version changes and other things which could effect our many pipelines and developers. Chose this option as the quickest path to a safe resolution. Would it help if I also made backport PR's for v9.x and v10.x?

@thymikee
Copy link
Member

Yeah, it would be best to backport to other versions as well. I could release that next week I guess

@thymikee
Copy link
Member

And also, since it's a small change, you could probably use patch-package in your project to avoid waiting

@jtparrett
Copy link
Author

@thymikee Awesome. We have a patch in place. But I will create backports for v9 and v10 also soon.

Thanks for the support!

@szymonrybczak
Copy link
Collaborator

I'm closing this PR since 0.69 (the version that 8.x corresponds to) is not longer supported, so Core Team will never release this change anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants