Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

followup: fix what #1029 broke #1053

Merged
merged 2 commits into from
Mar 16, 2020
Merged

followup: fix what #1029 broke #1053

merged 2 commits into from
Mar 16, 2020

Conversation

thymikee
Copy link
Member

@thymikee thymikee commented Mar 16, 2020 •
edited
Loading

Summary:

#1029 broke Android dependency discovery and --appId handling. Fixing it here.

cc @krizzu

Test Plan:

CI

Esemesek
Esemesek approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@Esemesek Esemesek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice :P

@thymikee thymikee merged commit 79498d5 into master Mar 16, 2020
@thymikee thymikee deleted the fix/followup-1029 branch March 16, 2020 15:47
@thymikee thymikee mentioned this pull request Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Esemesek Esemesek Esemesek approved these changes

@grabbou grabbou Awaiting requested review from grabbou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thymikee @Esemesek