feat(android): add appName; deprecate root, appFolder, appId #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
force-pushed
the
feat/android-use-config-2
branch
4 times, most recently
from
a0c89f9
to
b1b0ad8
Compare
thymikee
force-pushed
the
feat/android-use-config-2
branch
from
3827812
to
851f81e
Compare
krizzu
approved these changes
Mar 13, 2020
|
cc @Esemesek |
Esemesek
approved these changes
Mar 16, 2020
thymikee
added a commit
that referenced
this pull request
Mar 16, 2020
thymikee
added a commit
that referenced
this pull request
Mar 16, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding a new
platforms.android.appNameconfig, which infers Android app folder and id from available config data.--root,--appFolder,--appId.--appIdSuffix, when app uses flavorssourceDirto only look forandroid/directory, which is a Gradle root project – this alignssourceDirto iOS and allows for greater flexibility, becauseandroid/appwas a hardcoded name for a defaultappFolder, which would likely break stuff when somebody started usingappFolderflagFixes #781
Test Plan:
Updated tests, added new