Add spec for 1.63.0 CocoaPods distribution #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CFKevinRef thanks for sending this fix! I have no idea how this works but it looks reasonable. |
|
@grabbou and @ide - follow the signup/setup instructions in Getting Started and let me know what email I should use. I'll open a PR with README updates to make it part of the boost version bump process. |
|
@CFKevinRef how should I send you my email address to use? |
|
Sorry, didn't realize my email was private in my profile, fixed: KevinCassidyJr@gmail.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
Since React Native uses a header-only distribution of Boost, it's much more efficient to just preserve the
boost/directory structure and use this repo directly. Besides avoiding binary downloads, this should avoid a lot of unnecessary CocoaPods work on install.This is already available as the CocoaPod
boost-for-react-native. Let me know whose emails I should add as maintainers so it can be updated in the future.