-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cocoapods compatibility #3
Comments
@itchingpixels, thanks for digging the details. |
I'd be happy to do that, but haven't got around making it work just yet - I don't know what the delta is between this and the 1.59.0 release that's on cocoapods, but it's really confusing! |
it seems like there's some magic (at least to me) going on with preserve_paths that I don't understand (why is it needed at all?) in the original podspec. will try a few different things and report back. |
@ide, do you have some context on this to help us out? |
I don't have a lot of context around this and @mhorowitz set up the third-party pods. If we go in this direction I think we should just add a podspec to this repo to install direct from GitHub but not publish to CocoaPods since we're not going to remember to keep it updated. |
Pinged @mhorowitz, thanks @ide |
When I set up CocoaPods for CxxBridge, boost worked out of the box for me. I never even looked at the original Podspec, so I don't know why it's set up the way it is. My best guess why it isn't working now is that something in the maze of ifdefs changed, and now |
@mhorowitz
|
Great!!! Sorry guys that I backed out, had been super busy with a release... |
@itchingpixels I have a PR in your branch PR |
Anyone wants to send a PR for this repo? Thanks @fishmwei for finding the solution. |
I've created a PR: facebook/react-native#16756 |
Thanks, I'll ping iOS people internally |
@bestander do you have any news regarding this? I'm not sure whom should I be in contact with. |
+1 any update ? |
Trunk is still broken, I'll merge it once it is green: https://circleci.com/gh/facebook/react-native/tree/master. |
There's an issue on react-native I've opened: facebook/react-native#16381
I'm trying to use this version of boost instead of what's currently referred to as 'boost' in Folly.podspec, since the release version that can be downloaded from here is 4-5x smaller.
This is the podspec I've added
https://github.com/languagedrops/react-native/commit/1c3f1ab55aa8541bde2adbc4c4f25914a5731021
which should be the same as:
https://github.com/CocoaPods/Specs/blob/master/Specs/9/9/d/boost/1.59.0/boost.podspec.json
except the download URL.
But when I try to run the project with boost installed from this repo, I get the following error:
Are there any plans of making a pod out of this?
Thank you!
The text was updated successfully, but these errors were encountered: