Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max length validation to translated fields #1246

Conversation

MyPyDavid
Copy link
Member

Description

Related issue: #1244

Motivation and Context

Currently, translated fields are not validated for the max length. This PR adds it.

How has this been tested?

Screenshots (if appropriate)

Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid MyPyDavid self-assigned this Feb 18, 2025
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
@MyPyDavid MyPyDavid marked this pull request as ready for review February 19, 2025 12:24
@MyPyDavid MyPyDavid requested a review from jochenklar February 19, 2025 12:24
@MyPyDavid MyPyDavid added this to the RDMO 2.3.0 milestone Feb 19, 2025
Copy link
Member

@jochenklar jochenklar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@MyPyDavid MyPyDavid merged commit 1417153 into 2.3.0 Feb 20, 2025
19 checks passed
@MyPyDavid MyPyDavid mentioned this pull request Feb 20, 2025
@MyPyDavid MyPyDavid deleted the 1244-bug-in-saving-short-title-when-value-is-too-long-for-page-and-section branch February 24, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in saving short title when value is too long for page and section
2 participants