bug in saving short title when value is too long for page and section

[MyPyDavid]

Description / Beschreibung

 ERROR: Internal Server Error: /api/v1/questions/sections/
...
MySQLdb.DataError: (1406, "Data too long for column 'short_title_lang2' at row 1")
...
django.db.utils.DataError: (1406, "Data too long for column 'short_title_lang2' at row 1")

Expected behaviour / Erwartetes Verhalten

Saving a too long name for Short title shows an error eg. "given name is too long"

Could the max length value be passed to the front-end so that the JS can already validate the input while typing?

Steps to reproduce / Schritte zum Reproduzieren

1. Go to /management/pages/1 or /management/sections/1
2. add a long string for Short title
3. click save
4. See error

Context / Kontext

the RDMO 2.2.2 with MySQL.

Can not reproduce locally with sqlite.

References / Verweise

• rdmo/rdmo/questions/models/section.py

  Line 92 in 1eadee5

  short_title_lang1 = models.CharField(

• rdmo/rdmo/questions/serializers/v1/section.py

  Line 54 in 1eadee5

  'short_title',

[MyPyDavid]

• also for uri_path fields the Max Length validation is missing

[jochenklar]

Ok, I think manually setting uri_path = serializers.CharField(required=True) in the serializer created the problem, because the usual validation is skipped. If you remove this line the lenght is correctly validated, but the field is not required anymore.

[jochenklar]

It seems we need to use

        extra_kwargs = {
            'uri_path': {
                'required': True
            }
        }

in Meta instead of adding the field in the class. I can check all serializers tomorrow.

[jochenklar]

There are maybe other fields affected.

[MyPyDavid]

want to make this test parametrized for the different fields maybe?

rdmo/rdmo/questions/tests/test_viewset_page.py

Line 351 in 85e99c0

def test_update_page_field_validation_short_title(db, client):

[jochenklar]

I created #1250 for the issue. I don't think we need to add a test for this, since this would only test core Django/drf behavior. We (meaning I) learned how overriding serializer fields work.