Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR split off from PR #7 , which had become too unwieldly with its many edits.
This PR is focusing specifically to changes in library methods, and the tests to protect those methods.
The following library classes had refactors:
Splinor
: methods for different boundary conditions, split off duplicated coefficient methodsmatrix
: there was an error in the inversion process, caught by the new tests, now fixedstellar
: fixed misspelling the name of famous physicist Max PlanckThe following source code had to change in response to changes in the library:
constants
uses the correct spelling of PlanckSimpleWD
uses the correct spelling of PlanckIn addition, the following changes were made to source code:
Isopycnic
: fixed a typo in the surface coefficients oflight_speed2
definition, which instead just inherits fromStar
.MESA
: changed someint
s tosize_t
s, and updated certain surface expansion methods, which were erroneous.Polytrope
: removedlight_speed2
definition, which instead just inherits fromStar
Star
: replaces some string methods with new formatted strings, replaced someint
s withsize_t
s.ThrainMode
: fixed some finder methodsAnd now the changes to the tests:
matrix
: add extra test of tridiagonal inversionrootfind
: replaces theTS_ASSERT_IS_NAN(x)
method with more stable/secureTS_ASSERT(std::isnan(x))
Splinor
: many, many more tests, including using test data functions, and a test to create outputs to "artifacts" folderstring
: tests buffer overflowThrainMode
: replaces theTS_ASSERT_IS_NAN(x)
method with more stable/secureTS_ASSERT(std::isnan(x))
ThrainUnites
: adds a test of params method