Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance testing of library #9

Merged
merged 3 commits into from
Mar 24, 2024
Merged

Enhance testing of library #9

merged 3 commits into from
Mar 24, 2024

Conversation

rboston628
Copy link
Owner

@rboston628 rboston628 commented Mar 24, 2024

This PR split off from PR #7 , which had become too unwieldly with its many edits.

This PR is focusing specifically to changes in library methods, and the tests to protect those methods.

The following library classes had refactors:

  • Splinor: methods for different boundary conditions, split off duplicated coefficient methods
  • matrix: there was an error in the inversion process, caught by the new tests, now fixed
  • stellar: fixed misspelling the name of famous physicist Max Planck

The following source code had to change in response to changes in the library:

  • constants uses the correct spelling of Planck
  • SimpleWD uses the correct spelling of Planck

In addition, the following changes were made to source code:

  • Isopycnic: fixed a typo in the surface coefficients of $A^\ast$ and $V_g$. Also removed light_speed2 definition, which instead just inherits from Star.
  • MESA: changed some ints to size_ts, and updated certain surface expansion methods, which were erroneous.
  • Polytrope: removed light_speed2 definition, which instead just inherits from Star
  • Star: replaces some string methods with new formatted strings, replaced some ints with size_ts.
  • ThrainMode: fixed some finder methods

And now the changes to the tests:

  • adds CppCheck to CI/CD
  • many tests have had their print-outs suppressed during running tests, to make output mangeable
  • matrix: add extra test of tridiagonal inversion
  • rootfind: replaces the TS_ASSERT_IS_NAN(x) method with more stable/secure TS_ASSERT(std::isnan(x))
  • Splinor: many, many more tests, including using test data functions, and a test to create outputs to "artifacts" folder
  • string: tests buffer overflow
  • ThrainMode: replaces the TS_ASSERT_IS_NAN(x) method with more stable/secure TS_ASSERT(std::isnan(x))
  • ThrainUnites: adds a test of params method

@rboston628 rboston628 merged commit 05aece6 into main Mar 24, 2024
5 checks passed
@rboston628 rboston628 deleted the add-tests branch March 25, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant