Refactor with rootfinding library methods #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboston628
changed the title
|
One issue discovered in this was with the matrix inversion, which was surprisingly not caught by the tests. Incorrect choices in the indices of the re-substitution part were causing some mode calculations to fail. |
59 tasks
added 13 commits
May 1, 2024 17:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has individually re-written rootfinding methods all throughout it. This is not a desirable situation, and the better thing would be a single library with rootfinding methods that are all called where needed.
To do this, some careful testing is necessary, to ensure none of the routines relying on these methods accidentally break.
Testing was starting in PR #13. These changes are only to models covered by tests.