Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: discussions feature #87

Merged
merged 8 commits into from
Mar 14, 2022
Merged

feat: discussions feature #87

merged 8 commits into from
Mar 14, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Mar 9, 2022 •
edited
Loading

  • List all discussions with filter API
  • Create a new discussion API
  • Patch a discussion API
  • Get a discussion API

@mabdh mabdh self-assigned this Mar 9, 2022
@mabdh mabdh linked an issue Mar 9, 2022 that may be closed by this pull request
feat: discussion feature #47
Closed
@mabdh mabdh marked this pull request as draft March 9, 2022 04:32
@mabdh mabdh force-pushed the discussions-feature branch from af8986b to 3f89964 Compare March 9, 2022 07:13
@mabdh mabdh marked this pull request as ready for review March 9, 2022 08:08
@mabdh mabdh force-pushed the discussions-feature branch 2 times, most recently from 8e5064e to b663240 Compare March 9, 2022 11:15
StewartJingga
StewartJingga reviewed Mar 10, 2022
View reviewed changes
@mabdh mabdh force-pushed the discussions-feature branch from b4fe1ff to d26ae53 Compare March 10, 2022 12:16
@mabdh mabdh requested a review from StewartJingga March 11, 2022 03:07
@mabdh mabdh force-pushed the discussions-feature branch from 4d100d5 to 7ad90a1 Compare March 11, 2022 07:28
@mabdh mabdh mentioned this pull request Mar 11, 2022
Merged
@mabdh mabdh added the enhancement New feature or request label Mar 11, 2022
@mabdh
Copy link
Member Author

mabdh commented Mar 14, 2022

@StewartJingga updated, please check 🙏🏼

StewartJingga
StewartJingga previously approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo

@StewartJingga StewartJingga self-requested a review March 14, 2022 10:26
@StewartJingga StewartJingga dismissed their stale review March 14, 2022 10:26

has a typo

StewartJingga
StewartJingga approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabdh mabdh requested a review from StewartJingga March 14, 2022 10:51
@mabdh mabdh merged commit 9cb63a8 into main Mar 14, 2022
@mabdh mabdh deleted the discussions-feature branch March 14, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

@scortier scortier Awaiting requested review from scortier

@GrayFlash GrayFlash Awaiting requested review from GrayFlash

@StewartJingga StewartJingga Awaiting requested review from StewartJingga

Assignees

@mabdh mabdh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: discussion feature
2 participants
@mabdh @StewartJingga