feat: discussions comments and user/discussions api

[mabdh]

No description provided.

[StewartJingga]

Should we put comment in discussion package as it fully depends on discussion. We can also refer is as discussion.Comment.

Wdyt?

[mabdh]

@StewartJingga I think better to keep it in its own package. Even if it is fully dependent, would that be a problem?

My concern is, we need to have discussion.DiscussionRepository and discussion.CommentRepository instead of discussion.Repository alone.

[StewartJingga]

@StewartJingga I think better to keep it in its own package. Even if it is fully dependent, would that be a problem?

My concern is, we need to have discussion.DiscussionRepository and discussion.CommentRepository instead of discussion.Repository alone.

We can still keep discussion.Repository since the package name is discussion. Also we might not even need discussion.CommentRepository, we could have AddComment() method on discussion.Repository.

My concerns are:

1. Having comment as its own package could give a wrong impression that it is a standalone feature while it is not.
2. Having it under a discussion makes sense because they are the same domain and the hard dependency proves that.
3. Lastly (this is personal preference, can be ignored), discussion and comment are one feature and it feels good to know that we can port discussion feature to other codebase/module with just moving one folder (package/module).

[mabdh]

Having comment as its own package could give a wrong impression that it is a standalone feature while it is not.

It wouldn't really matter whether it is standalone feature or not right? We better keep the domain as granular as possible. I don't think combining comment inside discussion would matter that much.

Having it under a discussion makes sense because they are the same domain and the hard dependency proves that.

Yes it does make sense but again I don't think having hard dependency would really matter here

Lastly (this is personal preference, can be ignored), discussion and comment are one feature and it feels good to know that we can port discussion feature to other codebase/module with just moving one folder (package/module).

I agree on this. But it is also would make it easier to copy comment package if we need comments feature only in other use cases.

Anyway, let me try updating it according to your sugggestion.

[mabdh]

@StewartJingga comments moved to the discussion package, please review it again stew 🙏

[StewartJingga]

Small issue on swagger file

[StewartJingga]

LGTM, thanks for also removing old lineage api from swagger