Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): fix linting error #69

Merged
merged 5 commits into from
Jan 25, 2022
Merged

fix(lint): fix linting error #69

merged 5 commits into from
Jan 25, 2022

Conversation

scortier
Copy link
Member

@scortier scortier commented Jan 24, 2022 •
edited
Loading

  • Add golangci-lint to the workflow
  • Add lint command
  • Resolve linting errors

@scortier scortier marked this pull request as draft January 24, 2022 09:52
@scortier scortier marked this pull request as ready for review January 24, 2022 13:05
@scortier
Copy link
Member Author

Related Issues: #38 #39

This was linked to issues Jan 24, 2022
fix(lint): fix all linter warning #38
Closed
feat(lint): add golangci-lint to the workflow #39
Closed
mabdh
mabdh reviewed Jan 25, 2022
View reviewed changes
@scortier scortier requested a review from mabdh January 25, 2022 06:30
@mabdh
Copy link
Member

mabdh commented Jan 25, 2022

@scortier I still see github.com/pkg/errors package in go.mod. Have you tried doing go mod tidy?

@scortier
Copy link
Member Author

@scortier I still see github.com/pkg/errors package in go.mod. Have you tried doing go mod tidy?

Yes, I did

@mabdh mabdh merged commit 342ef0b into raystack:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdh mabdh mabdh approved these changes

Assignees

@scortier scortier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(lint): add golangci-lint to the workflow fix(lint): fix all linter warning
2 participants
@scortier @mabdh