Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): fix all linter warning #38

Closed
mabdh opened this issue Dec 10, 2021 · 0 comments · Fixed by #69
Closed

fix(lint): fix all linter warning #38

mabdh opened this issue Dec 10, 2021 · 0 comments · Fixed by #69
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mabdh
Copy link
Member

mabdh commented Dec 10, 2021

Is your feature request related to a problem? Please describe.
When doing lint with golangci-lint. I found there are several linter warning. We could fix all warning to avoid some unwanted bugs or unintended behaviour. After fixing all lint warning/error, we could add a new lint in github workflow.

Describe the solution you'd like
Fixing every line of code that throw lint warning/error when using golangci-lint.
@mabdh mabdh added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 10, 2021
@mabdh mabdh mentioned this issue Dec 10, 2021
Closed
@scortier scortier mentioned this issue Jan 24, 2022
Merged
@ravisuhag ravisuhag linked a pull request Jan 24, 2022 that will close this issue
fix(lint): fix linting error #69
Merged
@mabdh mabdh closed this as completed in #69 Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lint): fix linting error scortier/columbus
1 participant
@mabdh