Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lineage): delete lineage for the asset when deleting asset. #220

Merged
merged 1 commit into from
Mar 24, 2023
Merged

feat(lineage): delete lineage for the asset when deleting asset. #220

merged 1 commit into from
Mar 24, 2023

Conversation

anjali9791
Copy link
Contributor

Closes: #185

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4346424207

  • 27 of 38 (71.05%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 86.039%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/asset/errors.go 0 5 0.0%
internal/store/postgres/lineage_repository.go 15 21 71.43%
Totals Coverage Status
Change from base Build 4321301974: -0.1%
Covered Lines: 5035
Relevant Lines: 5852
💛 - Coveralls

@raystack raystack deleted a comment from sudo-suhas Mar 9, 2023
@kushsharma
Copy link
Member

LGTM

@ravisuhag ravisuhag merged commit acb3c90 into main Mar 24, 2023
@ravisuhag ravisuhag deleted the delete-lineage branch March 24, 2023 13:16
@sudo-suhas sudo-suhas mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudo-suhas sudo-suhas Awaiting requested review from sudo-suhas

@StewartJingga StewartJingga Awaiting requested review from StewartJingga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delete asset doesn't remove asset from lineage
5 participants
@anjali9791 @coveralls @kushsharma @ravisuhag @anjaliagg9791