Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear lineage during asset deletion #18

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix: clear lineage during asset deletion #18

merged 1 commit into from
Apr 19, 2023

Conversation

sudo-suhas
Copy link

Based on raystack#220

@sudo-suhas @anjaliagg9791
fix: clear lineage during asset deletion
58a3536 
Co-authored-by: Anjali Aggarwal <anjali.aggarwal@gojek.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4731961289

  • 15 of 19 (78.95%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 85.801%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/postgres/lineage_repository.go 8 12 66.67%
Totals Coverage Status
Change from base Build 4677166321: -0.03%
Covered Lines: 5082
Relevant Lines: 5923
💛 - Coveralls

@sudo-suhas sudo-suhas merged commit 4c21024 into main Apr 19, 2023
@sudo-suhas sudo-suhas deleted the delete-lineage branch April 19, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsushmith bsushmith bsushmith approved these changes

@StewartJingga StewartJingga Awaiting requested review from StewartJingga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudo-suhas @coveralls @bsushmith