Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] [easy] [no-op] Remove unused function argument #51024

Merged
merged 2 commits into from
Mar 3, 2025
Merged

[core] [easy] [no-op] Remove unused function argument #51024

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
715690c
remove unused function argument
dentiny Mar 3, 2025
5f32f29
fix caller
dentiny Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions python/ray/_private/function_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,9 +568,7 @@ def load_actor_class(self, job_id, actor_creation_function_descriptor):
)
method_id = method_descriptor.function_id
executor = self._make_actor_method_executor(
actor_method_name,
actor_method,
actor_imported=True,
actor_method_name, actor_method
)
self._function_execution_info[method_id] = FunctionExecutionInfo(
function=executor,
Expand Down Expand Up @@ -665,9 +663,7 @@ def _load_actor_class_from_gcs(self, job_id, actor_creation_function_descriptor)
actor_class.__module__ = module_name
return actor_class

def _make_actor_method_executor(
self, method_name: str, method, actor_imported: bool
):
def _make_actor_method_executor(self, method_name: str, method):
"""Make an executor that wraps a user-defined actor method.
The wrapped method updates the worker's internal state and performs any
necessary checkpointing operations.
Expand All @@ -676,9 +672,6 @@ def _make_actor_method_executor(
method: The actor method to wrap. This should be a
method defined on the actor class and should therefore take an
instance of the actor as the first argument.
actor_imported: Whether the actor has been imported.
Checkpointing operations will not be run if this is set to
False.
Returns:
A function that executes the given actor method on the worker's
stored instance of the actor. The function also updates the
Expand Down