Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] [easy] [no-op] Remove unused function argument #51024

Merged
merged 2 commits into from
Mar 3, 2025
Merged

[core] [easy] [no-op] Remove unused function argument #51024

merged 2 commits into from
Mar 3, 2025

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Mar 3, 2025

Function argument not used anywhere:

[~/ray] (master) 
ubuntu@hjiang-devbox-pg$ git grep "_make_actor_method_executor"
python/ray/_private/function_manager.py:                executor = self._make_actor_method_executor(
python/ray/_private/function_manager.py:    def _make_actor_method_executor(

@dentiny
remove unused function argument
715690c 
Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny added the go add ONLY when ready to merge, run all tests label Mar 3, 2025
@dentiny dentiny requested review from jjyao and edoakes March 3, 2025 00:40
@jjyao
Copy link
Collaborator

jjyao commented Mar 3, 2025

Many tests failed.

@dentiny dentiny closed this Mar 3, 2025
@dentiny dentiny reopened this Mar 3, 2025
@dentiny
fix caller
5f32f29 
Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny marked this pull request as draft March 3, 2025 11:52
@jjyao jjyao marked this pull request as ready for review March 3, 2025 15:55
@jjyao jjyao merged commit 72088cf into ray-project:master Mar 3, 2025
5 checks passed
Michaelhess17 pushed a commit to Michaelhess17/ray that referenced this pull request Mar 3, 2025
@dentiny @Michaelhess17
[core] [easy] [no-op] Remove unused function argument (ray-project#51024
ab3350a 
)

Signed-off-by: dentiny <dentinyhao@gmail.com>
xsuler pushed a commit to antgroup/ant-ray that referenced this pull request Mar 4, 2025
@dentiny @xsuler
[core] [easy] [no-op] Remove unused function argument (ray-project#51024
7ab803a 
)

Signed-off-by: dentiny <dentinyhao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyao jjyao jjyao approved these changes

@edoakes edoakes Awaiting requested review from edoakes

Assignees

@jjyao jjyao

@edoakes edoakes

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dentiny @jjyao @edoakes