Revert "Revert "[serve] Add initial health check before marking a rep… #31554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
zcin
force-pushed
the
revert-31548-revert-31189-check-health
branch
from
be5f82f to
f1dc5e3
Compare
edoakes
approved these changes
Jan 10, 2023
|
@zcin looks like there's a relevant mac build failure: |
|
@edoakes Passed after retrying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lica as RUNNING (#31189)" (#31548)"
This reverts commit 15676dd.
Why are these changes needed?
#31189 broke the Java codepath. This PR fixes that and also adds the initial health check to Java behavior.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.