Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[serve] Add initial health check before marking a replica as RUNNING" #31548

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Revert "[serve] Add initial health check before marking a replica as RUNNING" #31548

merged 1 commit into from
Jan 9, 2023

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Jan 9, 2023 •
edited
Loading

Reverts #31189
Screen Shot 2023-01-09 at 3 36 55 PM

@zcin zcin requested review from scv119 and edoakes January 9, 2023 23:39
@zcin
Revert "[serve] Add initial health check before marking a replica as …
a622f25 
…RUNNING (#31189)"

This reverts commit 6e5bb24.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin zcin force-pushed the revert-31189-check-health branch from 1e777b3 to a622f25 Compare January 9, 2023 23:43
@edoakes edoakes merged commit 15676dd into master Jan 9, 2023
@edoakes edoakes deleted the revert-31189-check-health branch January 9, 2023 23:48
@zcin zcin mentioned this pull request Jan 10, 2023
Merged
7 tasks
zcin added a commit that referenced this pull request Jan 10, 2023
@zcin
Revert "Revert "[serve] Add initial health check before marking a rep…
f84577c 
…lica as RUNNING (#31189)" (#31548)"

This reverts commit 15676dd.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
@zcin @AmeerHajAli
Revert "[serve] Add initial health check before marking a replica as …
fbf9ec1 
…RUNNING (#31189)" (#31548)

This reverts commit 6e5bb24.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

@scv119 scv119 Awaiting requested review from scv119

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcin @edoakes