Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] Ray Docker image for Python 3.9. #16571

Merged
merged 7 commits into from
Jul 22, 2021
Merged

[Build] Ray Docker image for Python 3.9. #16571

merged 7 commits into from
Jul 22, 2021

Conversation

mwtian
Copy link
Member

@mwtian mwtian commented Jun 21, 2021 •
edited
Loading

ray-ml / autoscaler images are skipped for Python 3.9, due to #16599.

Why are these changes needed?

Related issue number

#11287

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@mwtian mwtian changed the title Build Docker images for Python 3.9. [Build] Docker images for Python 3.9. Jun 21, 2021
@mwtian mwtian removed the 1.4.1 label Jun 21, 2021
@mwtian mwtian requested a review from simon-mo June 21, 2021 18:39
@mwtian mwtian added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 21, 2021
@mwtian mwtian force-pushed the build branch 6 times, most recently from 54d120b to d3293f2 Compare June 22, 2021 23:47
@simon-mo simon-mo assigned ijrsvt and unassigned simon-mo Jul 19, 2021
@simon-mo simon-mo requested review from ijrsvt and removed request for simon-mo July 19, 2021 17:17
ijrsvt
ijrsvt requested changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@ijrsvt ijrsvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 quick comments!

@mwtian mwtian removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jul 22, 2021
@mwtian mwtian changed the title [Build] Docker images for Python 3.9. [Build] Ray Docker image for Python 3.9. Jul 22, 2021
@mwtian mwtian requested a review from ijrsvt July 22, 2021 14:51
ijrsvt
ijrsvt approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@ijrsvt ijrsvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but otherwise LGTM!

@ijrsvt
Copy link
Contributor

ijrsvt commented Jul 22, 2021

Merging because this PR exclusively affects LINUX (and the failure is on MacOS).

@ijrsvt ijrsvt merged commit b8e71f6 into ray-project:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijrsvt ijrsvt ijrsvt approved these changes

@simon-mo simon-mo simon-mo approved these changes

Assignees

@ijrsvt ijrsvt

@DmitriGekhtman DmitriGekhtman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mwtian @ijrsvt @simon-mo @sven1977 @DmitriGekhtman