Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib][Tune] Build Ray-ML docker image for Python 3.9 #16599

Closed
mwtian opened this issue Jun 22, 2021 · 4 comments · Fixed by #28123
Closed

[RLlib][Tune] Build Ray-ML docker image for Python 3.9 #16599

mwtian opened this issue Jun 22, 2021 · 4 comments · Fixed by #28123
Assignees
Labels
bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks rllib RLlib related issues tune Tune-related issues

Comments

@mwtian
Copy link
Member

mwtian commented Jun 22, 2021

What is the problem?

Currently building Ray docker image with Python 3.9 times out, because some of the direct and transitive dependencies pinned in python/requirements/rllib/requirements_rllib.txt and python/requirements/tune/requirements_tune.txt do not support Python 3.9, and the pip dependency resolver goes into an edge case.

Ray version and other system information (Python version, TensorFlow version, OS):

Python 3.9, Ray 1.4.1

Reproduction (REQUIRED)

https://github.com/ray-project/ray/pull/16571/files

@mwtian mwtian added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 22, 2021
@amogkam
Copy link
Contributor

amogkam commented Jun 22, 2021

Hmm can we just not build Ray-ML Docker images for 3.9 for now?

The standard Ray docker images shouldn’t need requirements_rllib and requirements_tune

@amogkam
Copy link
Contributor

amogkam commented Jun 22, 2021

Also what’s the exact error you are getting?

another alternative is to just skip over the libraries that don’t have 3.9 support- something like this https://stackoverflow.com/questions/22250483/stop-pip-from-failing-on-single-package-when-installing-with-requirements-txt

@mwtian mwtian changed the title [RLlib][Tune] Build docker image for Python 3.9 [RLlib][Tune] Build Ray-ML docker image for Python 3.9 Jun 22, 2021
@mwtian
Copy link
Member Author

mwtian commented Jun 22, 2021

If it is ok with others to not build Ray-ML Docker images for 3.9, that can definitely be a solution.
The error I'm currently getting, after trying to update some dependencies, is https://buildkite.com/ray-project/ray-builders-pr/builds/7597#9190b10f-ce4d-428f-8c5e-c1e9d3835813/6-2858

@krfricke krfricke added P3 Issue moderate in impact or severity and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 28, 2021
@krfricke
Copy link
Contributor

cc @richardliaw do we have a target on when to fully support Python 3.9?

@richardliaw richardliaw added the rllib RLlib related issues label Oct 5, 2021
@acxz acxz mentioned this issue Dec 23, 2021
6 tasks
@wuisawesome wuisawesome added P1 Issue that should be fixed within a few weeks and removed P3 Issue moderate in impact or severity labels Mar 9, 2022
@amogkam amogkam added the tune Tune-related issues label Apr 18, 2022
@krfricke krfricke added this to the Tune P1 issue bash milestone May 3, 2022
@krfricke krfricke self-assigned this Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't P1 Issue that should be fixed within a few weeks rllib RLlib related issues tune Tune-related issues
Projects
None yet
5 participants