[feat] shorten RayClusterSuffix to have more space for RayService and RayJob names #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RayJob names Signed-off-by: Rueian <rueiancsie@gmail.com>
4 tasks
kevin85421
approved these changes
Feb 25, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, KubeRay adds different suffixes to make different services for a RayCluster. It will also trim these service names if they are too long to fit the 63-character limitation by k8s. However, the silent cut is not user-friendly as users can't easily know the resulting service names beforehand.
As a part of #3076: we are going to add a length validation to RayCluster names in v1.4 to make sure the silent cut does not take place while keeping sufficient room for the names specified by users, this PR shortens the
-raycluster-xxxxxRayCluster suffix to just-xxxxxfor RayJob and RayService, saving 11 characters for users to not be hit by the new length validation.Related issue number
Checks