-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][RayCluster] shorten HeadlessServiceSuffix to have more space for CR names #3101
[feat][RayCluster] shorten HeadlessServiceSuffix to have more space for CR names #3101
Conversation
can you split this into two PRs, one for headless service and one for RayCluster? |
cb99863
to
d67af8c
Compare
…or CR names Signed-off-by: Rueian <rueiancsie@gmail.com>
d67af8c
to
536d17a
Compare
Sure, another PR is here: #3102 |
Hi @andrewsykim, We'd like to add a length validation to RayCluster names in the next release to provide non-trimmed service names for a better user experience. But the current headless service suffix for the TPU webhook, Please let me know if you have any concerns about this. Thanks! |
I'll need to change the logic of the webhook here before this change so that |
GoogleCloudPlatform/ai-on-gke#1003 is merged. |
Why are these changes needed?
Currently, KubeRay adds different suffixes to make different services for a RayCluster. It will also trim these service names if they are too long to fit the 63-character limitation by k8s. However, the silent cut is not user-friendly as users can't easily know the resulting service names beforehand.
As a part of #3076: we are going to add a length validation to RayCluster names in v1.4 to make sure the silent cut does not take place while keeping sufficient room for the names specified by users, this PR shortens the
-headless-worker-svc
suffix to just-headless
, saving 11 characters for users to use (63-len("-serve-svc") = 53 characters).Related issue number
#3076
Checks