[REVIEW] Remove deprecated APIs #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
approved these changes
Jun 10, 2020
kkraus14
reviewed
Jun 10, 2020
Co-authored-by: Keith Kraus <kkraus@nvidia.com>
Deleting code is my favorite! |
|
This shouldn't be merged until @shwina's PR updates the IPC machinery to use Numba instead of |
jrhemstad
changed the title
jrhemstad
added
3 - Ready for review
jrhemstad
force-pushed
the
remove-deprecated-apis
branch
from
b278418 to
a4579d7
Compare
raydouglass
approved these changes
Jun 11, 2020
|
@jrhemstad - yup, LGTM |
shwina
approved these changes
Jun 11, 2020
kkraus14
added
5 - Ready to Merge
kkraus14
approved these changes
Jun 11, 2020
This was referenced Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #401
Closes: #302 #301 #305
Furthermore, removes the
rmmGetAllocationOffsetfunction. This was simply a wrapper aroundcuMemGetAddressRangeto get the head address of a pool for an IPC handle. However, Numba already provides a wrapper around this API. So there's no longer a need for RMM to provide it (which has the added benefit of RMM no longer needs to link against the driver API).After this PR, the only thing preventing RMM from being header only is CNMeM.