-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to deprecated rmm headers. #240
Merged
kkraus14
merged 2 commits into
rapidsai:branch-0.15
from
jrhemstad:remove-deprecated-rmm-header
Jun 12, 2020
Merged
Remove references to deprecated rmm headers. #240
kkraus14
merged 2 commits into
rapidsai:branch-0.15
from
jrhemstad:remove-deprecated-rmm-header
Jun 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
trxcllnt
approved these changes
Jun 11, 2020
rerun tests |
harrism
approved these changes
Jun 11, 2020
|
That's odd... maybe that header's not in the conda package yet? These are the paths CMake is using:
|
Oh that's definitely it. This header was added 9 hours ago: rapidsai/cudf@ad9dea1 |
rerun tests |
kkraus14
approved these changes
Jun 12, 2020
This PR missed the calls to rmmInitialize and rmmFinalize in benchmark_fixture.hpp (though it deleted the #include. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapidsai/rmm#396 removed all deprecated headers and APIs.
This PR cleans up references to unused, deprecated RMM headers.