Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to deprecated rmm headers. #240

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

jrhemstad
Copy link
Contributor

rapidsai/rmm#396 removed all deprecated headers and APIs.

This PR cleans up references to unused, deprecated RMM headers.

@jrhemstad jrhemstad requested a review from a team as a code owner June 11, 2020 21:59
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@trxcllnt
Copy link
Contributor

rerun tests

@harrism
Copy link
Member

harrism commented Jun 11, 2020

[ 40%] Building CXX object tests/CMakeFiles/POINT_IN_POLYGON_TEST.dir/spatial/point_in_polygon_test.cpp.o
In file included from /var/lib/jenkins/workspace/rapidsai/gpuci/cuspatial/prb/cuspatial-gpu-build_3/cpp/tests/spatial/hausdorff_test.cpp:21:0:
/var/lib/jenkins/workspace/rapidsai/gpuci/cuspatial/prb/cuspatial-gpu-build_3/cudf/cpp/tests/utilities/column_wrapper.hpp:37:10: fatal error: cudf/lists/lists_column_view.hpp: No such file or directory
 #include <cudf/lists/lists_column_view.hpp>

@trxcllnt
Copy link
Contributor

That's odd... maybe that header's not in the conda package yet? These are the paths CMake is using:

-- CUDF: CUDF_HOME set to /var/lib/jenkins/workspace/rapidsai/gpuci/cuspatial/prb/cuspatial-gpu-build_3/cudf
-- CUDF: CUDF_LIBRARY set to /opt/conda/envs/gdf/lib/libcudf.so
-- CUDF: CUDF_INCLUDE set to /opt/conda/envs/gdf/include

@trxcllnt
Copy link
Contributor

Oh that's definitely it. This header was added 9 hours ago: rapidsai/cudf@ad9dea1

@trxcllnt
Copy link
Contributor

rerun tests

@kkraus14 kkraus14 added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jun 12, 2020
@kkraus14 kkraus14 merged commit 2aec2af into rapidsai:branch-0.15 Jun 12, 2020
@harrism
Copy link
Member

harrism commented Jun 15, 2020

This PR missed the calls to rmmInitialize and rmmFinalize in benchmark_fixture.hpp (though it deleted the #include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants