Restore support for Python 3.9 #21
Conversation
There was a problem hiding this comment.
Thanks!
I thought that maybe typing.Union was deprecated and that's why I saw so much RAPIDS code preferring the x | y type of syntax. But checked https://docs.python.org/3/library/stdtypes.html#types-union and I don't see any indication of that, so totally support this.
To help others understand the purpose for this PR if they find it in the future, linking these two things here:
- these hints were introduced in add mypy to linting checks #19
- ... but only tested with Python 3.10, and broke when used in a Python 3.9 build on Use rapids-build-backend cuml#5804 (build link)
I left one small comment, but do what you want with it... I don't need to review again.
There was a problem hiding this comment.
Is it possible to continue using the latest CI images and instead configure mypy to do type-checking with Python 3.9 support? https://mypy.readthedocs.io/en/stable/config_file.html#confval-python_version
|
We could, but I really want to test the whole thing with Python 3.9 anyway, to prevent the usage of other post-3.9 features. |
#21 restored Python 3.9 support, but used hard-coded CI images. Use https://github.com/rapidsai/shared-workflows to select an appropriate CI image.
#19 added MyPy linting, but CI did not run under Python 3.9, so the new type annotation syntax was used. Use the old syntax to support Python 3.9, and run CI in Python 3.9.