add mypy to linting checks #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
jameslamb
commented
May 2, 2024
KyleFromNVIDIA
requested changes
May 2, 2024
KyleFromNVIDIA
approved these changes
May 2, 2024
KyleFromNVIDIA
added a commit
that referenced
this pull request
May 3, 2024
#19 added MyPy linting, but CI did not run under Python 3.9, so the new type annotation syntax was used. Use the old syntax to support Python 3.9, and run CI in Python 3.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading through this project's code for work on rapidsai/build-planning#31, I noticed it isn't using type hints or running a type-checking
This proposes the following:
mypyto checks run via pre-commitI think this'll make the code a little easier to understand, and improve the change of catching some types of bugs (like treating a value which can be
Noneas if it was unconditionally not `None) during development.How I tested this