-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid the use of shared variable. #50
Conversation
- Use register instead. - Fix Python benchmark script.
@hcho3 Have you seen this error using the rapids test matrix generator:
with |
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
The failure on this PR is due to the addition of CUDA 12.5 support. This repository was missed during the upgrade. rapidsai/build-planning#73 I went ahead and pushed the changes you need in 444005e. |
I also pushed commit e04ea9b with the changes from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving packaging changes. Thanks for the fix @trivialfis. Hope it's alright with the team that I am approving my own fixes, nothing should be controversial here (just missed version updates) and should unblock CI.
I ran the Python benchmark script using RTX8000 with CPU excluded:
PR
main