Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update panel version #361

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

AjayThorve
Copy link
Member

fixes #360

@AjayThorve AjayThorve requested a review from a team as a code owner March 29, 2022 20:12
@github-actions github-actions bot added the conda label Mar 29, 2022
@AjayThorve AjayThorve added non-breaking Non-breaking change conda bug Something isn't working and removed conda labels Mar 29, 2022
@AjayThorve
Copy link
Member Author

waiting for panel 0.12.7 to be uploaded to conda-forge for CI to pass

@jakirkham
Copy link
Member

Thanks Ajay! 😀

Should we update the integration repo's panel version constraint as well?

@mmccarty
Copy link
Contributor

You could also pin jinja2=2.11.3, if there are no other issues with that version.

@jakirkham
Copy link
Member

jakirkham commented Mar 29, 2022

Yeah we were planning to update to the new panel package once released. Already have PR ( conda-forge/panel-feedstock#48 ) up to fix that. Just need a review from the panel developers.

@AjayThorve
Copy link
Member Author

You could also pin jinja2=2.11.3, if there are no other issues with that version.

I think there might be, the @rapidsai/docker repo has pinned the jinja2 package at a higher version (https://github.com/rapidsai/docker/blob/branch-22.04/requirements.txt) for CI

@ajschmidt8
Copy link
Member

ajschmidt8 commented Mar 29, 2022

You could also pin jinja2=2.11.3, if there are no other issues with that version.

I think there might be, the @rapidsai/docker repo has pinned the jinja2 package at a higher version (https://github.com/rapidsai/docker/blob/branch-22.04/requirements.txt) for CI

That's safe to ignore. I can adjust that pin if necessary. It doesn't have any effect on any of the other RAPIDS packages.

@AjayThorve
Copy link
Member Author

You could also pin jinja2=2.11.3, if there are no other issues with that version.

I think there might be, the @rapidsai/docker repo has pinned the jinja2 package at a higher version (https://github.com/rapidsai/docker/blob/branch-22.04/requirements.txt) for CI

That's safe to ignore. I can adjust that pin if necessary. It doesn't have any effect on any of the other RAPIDS packages.

Well in that case, pinning jinja2 might resolve panel issues without waiting for a 0.12.7 release, if that works, I'll go ahead and push the pin for that as well!

@AjayThorve
Copy link
Member Author

Thanks Ajay! grinning

Should we update the integration repo's panel version constraint as well?

@jakirkham added the PR to integration repo -> rapidsai/integration#454

@jakirkham
Copy link
Member

panel has been updated 😀

@ajschmidt8
Copy link
Member

panel has been updated grinning

I think we can unpin the Jinja pkg now then, right?

@AjayThorve
Copy link
Member Author

panel has been updated grinning

I think we can unpin the Jinja pkg now then, right?

yep, just tested locally, newer panel works with all jinja versions, unpinned it.

@github-actions github-actions bot added the gpuCI label Mar 30, 2022
@ajschmidt8
Copy link
Member

rerun tests

@ajschmidt8
Copy link
Member

admin merging since all tests have passed except arm due to some machine issues.

@ajschmidt8 ajschmidt8 merged commit 56bff7c into rapidsai:branch-22.04 Mar 30, 2022
@jakirkham
Copy link
Member

Thanks all! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ImportError in Panel when importing cuxfilter
4 participants