Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require setuptools in run <61 #48

Merged

Conversation

jakirkham
Copy link
Member

Should hopefully fix CI builds, which are failing atm.

Note didn't bump the build number as the builds are failing without this. So there are no packages to supersede.

We may also need to hot-fix past versions if this is needed there as well. For example ( conda-forge/conda-forge-repodata-patches-feedstock#204 ).

cc @philippjfr @maximlt

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member Author

Do we need this setuptools constraint for earlier versions of panel?

@jakirkham
Copy link
Member Author

This appears to be working 🎉

Would be good to get some feedback on the question above 🙂

@jakirkham
Copy link
Member Author

Submitted draft PR ( conda-forge/conda-forge-repodata-patches-feedstock#245 ) for hotfixing. Though would be good to confirm that is doing what we expect.

@philippjfr
Copy link
Contributor

I don't think I should have pinned setuptools<61 as a runtime dependency in the Panel release. Due to the jinja2 breakage I wanted to push a release out quickly and since our build infrastructure had broken due to setuptools 61 I had to pin it in various places. The next release should not have this problem so I'll remove the pin again. @maximlt Please chime in if you think that's incorrect, for now I'm personally happy to se this merged.

@maximlt
Copy link
Contributor

maximlt commented Mar 30, 2022

Happy to see this merged too, I had not realized setuptools was also pinned in the runtime dependencies. For the next release we should revert all these changes here and in Panel.

@philippjfr philippjfr merged commit 5a1d748 into conda-forge:main Mar 30, 2022
@jakirkham
Copy link
Member Author

It should be possible to remove setuptools as a runtime dependency. Please see issue ( holoviz/panel#3282 ) for details 🙂

@jakirkham jakirkham deleted the fix_setuptools_req branch March 30, 2022 10:09
@maximlt
Copy link
Contributor

maximlt commented Mar 30, 2022

Thanks @jakirkham !!!

@djhoese
Copy link

djhoese commented Mar 31, 2022

I commented on the original PR here, but this seems like a better place for the discussion.

But what is the recommendation for projects that need 0.12.7 of panel? If you don't force the version you get 0.12.6 because conda chooses the newer setuptools. Since it looks like conda-forge/conda-forge-repodata-patches-feedstock#245 is going to be closed, this means that most users won't automatically get the fixes of 0.12.7.

Note my project does not directly depend on panel.

@jakirkham
Copy link
Member Author

Require 0.12.7 or greater?

Yeah repodata patches are one way we try to solve these kinds of issues. However we usually only add that if there was some new version of a library that broke the current version of a package and all prior versions. That isn't really the case here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants