-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require setuptools
in run
<61
#48
Require setuptools
in run
<61
#48
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Do we need this |
This appears to be working 🎉 Would be good to get some feedback on the question above 🙂 |
Submitted draft PR ( conda-forge/conda-forge-repodata-patches-feedstock#245 ) for hotfixing. Though would be good to confirm that is doing what we expect. |
I don't think I should have pinned setuptools<61 as a runtime dependency in the Panel release. Due to the jinja2 breakage I wanted to push a release out quickly and since our build infrastructure had broken due to setuptools 61 I had to pin it in various places. The next release should not have this problem so I'll remove the pin again. @maximlt Please chime in if you think that's incorrect, for now I'm personally happy to se this merged. |
Happy to see this merged too, I had not realized setuptools was also pinned in the runtime dependencies. For the next release we should revert all these changes here and in Panel. |
It should be possible to remove |
Thanks @jakirkham !!! |
I commented on the original PR here, but this seems like a better place for the discussion. But what is the recommendation for projects that need 0.12.7 of panel? If you don't force the version you get 0.12.6 because conda chooses the newer setuptools. Since it looks like conda-forge/conda-forge-repodata-patches-feedstock#245 is going to be closed, this means that most users won't automatically get the fixes of 0.12.7. Note my project does not directly depend on panel. |
Require Yeah repodata patches are one way we try to solve these kinds of issues. However we usually only add that if there was some new version of a library that broke the current version of a package and all prior versions. That isn't really the case here. |
Should hopefully fix CI builds, which are failing atm.
Note didn't bump the build number as the builds are failing without this. So there are no packages to supersede.
We may also need to hot-fix past versions if this is needed there as well. For example ( conda-forge/conda-forge-repodata-patches-feedstock#204 ).
cc @philippjfr @maximlt
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)