-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test with CUDA 12.5.1 #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small change, looks like the conda env file mentioned here needs to be updated:
Line 105 in 37fe9f4
mamba env create --name cuvs -f conda/environments/all_cuda-120_arch-x86_64.yaml |
And I think we'll want to update these cuda-version
references in docs as well:
Line 46 in 37fe9f4
mamba install -c rapidsai -c conda-forge -c nvidia libcuvs cuda-version=12.0 |
Line 53 in 37fe9f4
mamba install -c rapidsai -c conda-forge -c nvidia libcuvs cuda-version=12.0 |
Line 60 in 37fe9f4
mamba install -c rapidsai -c conda-forge -c nvidia cuvs cuda-version=12.0 |
context: rapidsai/cudf#16259 (comment)
Marking this "approve" so you don't have to wait for another review from me.
I've updated https://github.com/rapidsai/rapids-reviser/pull/42 to also update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you.
/merge |
Follow up to PR: #219 Partially addresses issue: rapidsai/build-planning#73 Renames the `.devcontainer`s for CUDA 12.5 cc @KyleFromNVIDIA @jameslamb @trxcllnt (for awareness) Authors: - https://github.com/jakirkham Approvers: - Paul Taylor (https://github.com/trxcllnt) - James Lamb (https://github.com/jameslamb) URL: #224
This PR updates the latest CUDA build/test version 12.2.2 to 12.5.1.
Contributes to rapidsai/build-planning#73