-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test with CUDA 12.5.1 #16259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one other place that needs to be updated:
Line 107 in a6de6cc
conda env create --name cudf_dev --file conda/environments/all_cuda-122_arch-x86_64.yaml |
Since the name of the conda env file checked into conda/environments
is changing (-122
to -125
), mentions of it in docs need to change.
Many of the RAPIDS projects have similar lines in their docs that describe using the files in conda/environments
for local development (although of the ones I've looked at today, most are still using the CUDA 11.8 env), so I think it'd be worth adding this to the rapids-reviser
migration script so such things aren't missed the next time we do an update like this.
how I found this
I've been doing the following while reviewing these CUDA 12.5 PRs:
# look for other uses of CUDA 12.2
git grep -E '12\.2'
# look for references to the conda env files
git grep -E 'all_cuda'
git grep -E '\-122'
I've updated https://github.com/rapidsai/rapids-reviser/pull/42 to update conda environments and docs, updated this PR, and also updated rapidsai/cugraph#4534. |
/merge |
Thanks all! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KyleFromNVIDIA This directory needs to be renamed from 12.2 to 12.5. Maybe we can get by with just one devcontainer per major version, and use only “11” and “12”? Perhaps that would be worth discussing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bradley! 🙏
We missed this on review. Sorry about that
Have simply renamed in PR: #16293 (this is what we needed to do in a couple other places already)
We can discussing renaming separately. Would want to hear from Paul on that
Follow up to PR: #16259 Partially addresses issue: rapidsai/build-planning#73 Renames the `.devcontainer`s for CUDA 12.5 Authors: - https://github.com/jakirkham Approvers: - James Lamb (https://github.com/jameslamb) - Paul Taylor (https://github.com/trxcllnt) URL: #16293
This PR updates the latest CUDA build/test version 12.2.2 to 12.5.1.
Contributes to rapidsai/build-planning#73