Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_intersections.py post cudf refactor #1398

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

mroeschke
Copy link
Contributor

Description

closes #1395

pairwise_linestring_intersection, tested in this file, returns a cudf.Column for one of it's arguments and used to_pandas to test it's output. in 24.08, the output of Column.to_pandas was changed to a pandas.Index instead of a pandas.Series so modified the test accordingly

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner June 7, 2024 03:07
@mroeschke mroeschke requested review from thomcom and harrism June 7, 2024 03:07
@github-actions github-actions bot added the Python Related to Python code label Jun 7, 2024
@harrism harrism added non-breaking Non-breaking change bug Something isn't working labels Jun 7, 2024
@harrism
Copy link
Member

harrism commented Jun 7, 2024

failing doxygen build due to warnings. Weird that this hasn't happened before?

@trxcllnt
Copy link
Contributor

trxcllnt commented Jun 7, 2024

It looks like import cudf is now calling getDeviceCount(). Was this recently changed in cuDF? I don't recall needing a GPU just to import cudf?

@wence-
Copy link
Contributor

wence- commented Jun 7, 2024

It looks like import cudf is now calling getDeviceCount(). Was this recently changed in cuDF? I don't recall needing a GPU just to import cudf?

No. cudf has done validation like that by default since approximately forever (e.g. https://github.com/rapidsai/cudf/blame/070953239a72a669d9f53f48efd85960ac70c381/python/cudf/cudf/__init__.py). See also rapidsai/cudf#4827

@bdice
Copy link
Contributor

bdice commented Jun 7, 2024

Rerunning CI seems to have fixed the issues. This is blocking CI for other PRs, so I will merge it.

@bdice
Copy link
Contributor

bdice commented Jun 7, 2024

/merge

@rapids-bot rapids-bot bot merged commit 8de055c into rapidsai:branch-24.08 Jun 7, 2024
70 checks passed
@mroeschke mroeschke deleted the fix/test/intersection branch June 7, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Related to Python code
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

[BUG]: test_intersections tests failing on 24.08
6 participants