Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: test_intersections tests failing on 24.08 #1395

Closed
jameslamb opened this issue Jun 6, 2024 · 3 comments · Fixed by #1398
Closed

[BUG]: test_intersections tests failing on 24.08 #1395

jameslamb opened this issue Jun 6, 2024 · 3 comments · Fixed by #1398
Labels
bug Something isn't working

Comments

@jameslamb
Copy link
Member

jameslamb commented Jun 6, 2024 •
edited
Loading

Version

24.08

On which installation method(s) does this occur?

No response

Describe the issue

I'm seeing these tests fail across PRs targeting branch-24.08:

FAILED tests/basicpreds/test_intersections.py::test_one_pair - AssertionError: Series Expected type <class 'pandas.core.series.Series'>, found <class 'pandas.core.indexes.base.Index'> instead
FAILED tests/basicpreds/test_intersections.py::test_two_pairs - AssertionError: Series Expected type <class 'pandas.core.series.Series'>, found <class 'pandas.core.indexes.base.Index'> instead
FAILED tests/basicpreds/test_intersections.py::test_one_pair_with_overlap - AssertionError: Series Expected type <class 'pandas.core.series.Series'>, found <class 'pandas.core.indexes.base.Index'> instead
FAILED tests/basicpreds/test_intersections.py::test_two_pairs_with_intersect_and_overlap - AssertionError: Series Expected type <class 'pandas.core.series.Series'>, found <class 'pandas.core.indexes.base.Index'> instead
FAILED tests/basicpreds/test_intersections.py::test_one_pair_multilinestring - AssertionError: Series Expected type <class 'pandas.core.series.Series'>, found <class 'pandas.core.indexes.base.Index'> instead
FAILED tests/basicpreds/test_intersections.py::test_three_pairs_identical_has_ring - AssertionError: Series Expected type <class 'pandas.core.series.Series'>, found <class 'pandas.core.indexes.base.Index'> instead
FAILED tests/basicpreds/test_intersections.py::test_three_pairs_identical_no_ring - AssertionError: Series Expected type <class 'pandas.core.series.Series'>, found <class 'pandas.core.indexes.base.Index'> instead

Minimum reproducible example

Observed this in the following PRs:

ref: #1393 (comment)

Relevant log output

No response

Environment details

In those failing PRs, I see these relevant versions:

cudf                      24.08.00a106    cuda11_py39_240605_g20aa4442d2_106    rapidsai-nightly
...
geopandas                 0.14.4             pyhd8ed1ab_0    conda-forge
geopandas-base            0.14.4             pyha770c72_0    conda-forge
...
pandas                    2.2.2            py39hfc16268_1    conda-forge
...
pyarrow                   16.1.0           py39h8003fee_1    conda-forge
pyarrow-core              16.1.0          py39h176f5a7_1_cpu    conda-forge

I see the failures across all combinations of Python version, CUDA version, and architecture... and for both wheels and conda packages.

(example build logs)

Other/Misc.

No response
@jameslamb jameslamb added the bug Something isn't working label Jun 6, 2024
@github-project-automation github-project-automation bot moved this to Todo in cuSpatial Jun 6, 2024
@jameslamb jameslamb mentioned this issue Jun 6, 2024
Merged
@vyasr
Copy link
Contributor

vyasr commented Jun 7, 2024

With no investigation, just based on the fact that we're seeing an Index where a Series was expected, I'm going to guess that this is rapidsai/cudf#15833 @mroeschke

@mroeschke mroeschke mentioned this issue Jun 7, 2024
Merged
3 tasks
@mroeschke
Copy link
Contributor

Oops sorry opened #1398 to address this

@rapids-bot rapids-bot bot closed this as completed in #1398 Jun 7, 2024
rapids-bot bot pushed a commit that referenced this issue Jun 7, 2024
@mroeschke
Fix test_intersections.py post cudf refactor (#1398)
8de055c 
closes #1395

`pairwise_linestring_intersection`, tested in this file, returns a `cudf.Column` for one of it's arguments and used `to_pandas` to test it's output. in 24.08, the output of `Column.to_pandas` was changed to a `pandas.Index` instead of a `pandas.Series` so modified the test accordingly

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Paul Taylor (https://github.com/trxcllnt)
  - Michael Wang (https://github.com/isVoid)

URL: #1398
@github-project-automation github-project-automation bot moved this from Todo to Done in cuSpatial Jun 7, 2024
@jameslamb
Copy link
Member Author

Thanks very much @mroeschke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test_intersections.py post cudf refactor mroeschke/cuspatial
3 participants
@vyasr @jameslamb @mroeschke