Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Bug ext two graphs #239

Merged
merged 14 commits into from
Apr 24, 2019
Merged

[REVIEW] Bug ext two graphs #239

merged 14 commits into from
Apr 24, 2019

Commits on Apr 22, 2019

  1. replaced tab with space and fixed wierd indentations in two_hop_neigh… 

    …bors.cu
    @seunghwak
    seunghwak committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    75a9b54 View commit details
    Browse the repository at this point in the history

  2. replaced tab with space and fixed inconsistent indentations and forma… 

    …tting in comments in functions.h
    @seunghwak
    seunghwak committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    e82394f View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. multiple renamings (renamed num_vertices to number_of_vertices, Netwo… 

    …rkX has number_of_nodes, so the new name is closer to the NetworkX name, we haven't decided to use either node or vertex in the user facing API yet, so we stick to vertex up to this point, both num_vert and num_verts are used, and renamed num_vert to num_verts, cuGraph mostly uses vertex but node is used in several places, so renamed node(s) to vertex (or vertices) to improve consistency)
    @seunghwak
    seunghwak committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    542b087 View commit details
    Browse the repository at this point in the history

  2. udpated number_of_vertices() to consider an empty graph

    @seunghwak
    seunghwak committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    692e7a6 View commit details
    Browse the repository at this point in the history

  3. added number_of_edges() and replaced direct access to the gdf_graph s… 

    …tructure to get the number of edges (e.g. g.adjList.indices.size) with the number_of_edges() function call
    @seunghwak
    seunghwak committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    9eb7708 View commit details
    Browse the repository at this point in the history

  4. renamed resultSize to result_size to be consistent with the code base… 

    … (and flake8 compatible)
    @seunghwak
    seunghwak committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    dce54aa View commit details
    Browse the repository at this point in the history

  5. updated cugraph to add a new graph only if the graph is empty, raise … 

    …a GDFError (GDF_INVALID_API_CALL) if this condition is not met.
    @seunghwak
    seunghwak committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    f8b321f View commit details
    Browse the repository at this point in the history

  6. added a test case for the update to prevent adding a new graph to a n… 

    …on-empty graph
    @seunghwak
    seunghwak committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    3c8b203 View commit details
    Browse the repository at this point in the history

  7. removed an unnecessary import

    @seunghwak
    seunghwak committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    07e7f8c View commit details
    Browse the repository at this point in the history

  8. updated change log

    @seunghwak
    seunghwak committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    be29f9c View commit details
    Browse the repository at this point in the history

  9. Merge branch 'branch-0.7' into bug_ext_two_graphs

    @seunghwak
    seunghwak authored Apr 23, 2019
    Configuration menu
    Copy the full SHA
    9527c3c View commit details
    Browse the repository at this point in the history

  10. removed redundant check

    @seunghwak
    seunghwak committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    675fb2d View commit details
    Browse the repository at this point in the history

  11. updated change log

    @seunghwak
    seunghwak committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    06b2f17 View commit details
    Browse the repository at this point in the history

  12. updated change log

    @seunghwak
    seunghwak committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    ca49a31 View commit details
    Browse the repository at this point in the history