[REVIEW] Bug ext two graphs #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting in comments in functions.h
…rkX has number_of_nodes, so the new name is closer to the NetworkX name, we haven't decided to use either node or vertex in the user facing API yet, so we stick to vertex up to this point, both num_vert and num_verts are used, and renamed num_vert to num_verts, cuGraph mostly uses vertex but node is used in several places, so renamed node(s) to vertex (or vertices) to improve consistency)
…tructure to get the number of edges (e.g. g.adjList.indices.size) with the number_of_edges() function call
… (and flake8 compatible)
…a GDFError (GDF_INVALID_API_CALL) if this condition is not met.
afender
reviewed
Apr 23, 2019
cpp/src/cugraph.cu
Outdated
| //representation to prevent a single object storing two different graphs. | ||
| GDF_REQUIRE( ((graph->edgeList == nullptr) && (graph->adjList == nullptr) && | ||
| (graph->transposedAdjList == nullptr)), GDF_INVALID_API_CALL); | ||
| GDF_REQUIRE( (graph->transposedAdjList == nullptr) , GDF_INVALID_API_CALL); |
There was a problem hiding this comment.
Thanks for finding this and I made a fix!
afender
reviewed
Apr 23, 2019
| else: | ||
| elif g.edgeList: | ||
| # This code needs to be revisited when updating gdf_graph. Users | ||
| # may expect numbrer_of_vertcies() as a cheap query but this |
There was a problem hiding this comment.
Agreed, I created #241 for this. I don't expect many users to upload an edge list and directly ask for the number of vertices before actually running any analytics. So it would be nice to have but I don't see it as a top priority.
afender
approved these changes
Apr 24, 2019
ChuckHastings
pushed a commit
to ChuckHastings/cugraph
that referenced
this pull request
Jun 14, 2021
[gpuCI] Forward-merge branch-21.06 to branch-21.08 [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #187