-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Python tests take too long #83
Comments
If reducing the problem sizes for speeding up networkx is not an option, why not precompute the expected results and then compare to this saved results to skip networkx long processing time? |
The problem sizes look quite small already but we can consider reducing it further. As long as it is large enough to run on multiple SMs that's good enough. I agree that, for tests where Nx will be identified as the bottleneck, we can generate and save some golden data. We already do that for several internal C++ tests actually. |
Please assign this to me. I am going to start working on it. |
PR updates RAFT's CMake and uses CPM for dependency management. Still WIP, meant for early 0.20, but opening the PR to start debugging in CI. This is heavily based on cuDF's, RMM's and cumlprims' changes. PR does the following: - [x] Adopt CPM: - [x] RMM - [x] FAISS - [x] GTest - [ ] NCCL: Missing building from source, will be added if/when required - [ ] UCX: Missing building from source, will be added if/when required - [x] CUB for CUDA < 11.0 - [x] Update arch detection - [x] Use generators to allow clang compilation as well - [x] Updates to outdated cmake parts and remove old code - [x] Update code to aid transition to rapidsai#83 Authors: - Dante Gama Dessavre (https://github.com/dantegd) - Robert Maynard (https://github.com/robertmaynard) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Rick Ratzel (https://github.com/rlratzel) - Divye Gala (https://github.com/divyegala) URL: rapidsai/raft#187
Python tests take more than 30 min to run. This is blocking the testing platform for too long. Users may also think that something is not working correctly.
We should identify what takes so long (afaik, most of the time is spent in NextworkX to get the reference result) and try to reduce the total time as much as possible.
The text was updated successfully, but these errors were encountered: