Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] python tests: missing, fail, take very long, and generate warnings. #80

Closed
seunghwak opened this issue Feb 15, 2019 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@seunghwak
Copy link
Contributor

seunghwak commented Feb 15, 2019

cugraph/jaccard/test_jaccard.py
Aborted (core dumped)

cugraph/grmat & cugraph/nvgraph
no test

cugraph/luvain, cugraph/pagerank, & cugraph/sssp
deprecated API warning

cugraph/graph/test_graph.py
take very long (#83)

====================================== warnings summary =======================================
/home/seunghwak/Program/anaconda3/envs/cugraph_dev/lib/python3.7/site-packages/yaml/constructor.py:126: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
if not isinstance(key, collections.Hashable):

-- Docs: https://docs.pytest.org/en/latest/warnings.html

@seunghwak seunghwak added ? - Needs Triage Need team to review and classify bug Something isn't working labels Feb 15, 2019
@afender
Copy link
Member

afender commented Feb 19, 2019

Is this an output from the testing platform or your own machine? Tests are passing for me (latest version in branch-0.6). I believe @aschaffer and @jwyles successfully ran these tests very recently as well. Please add more details about how you ran it and work with the team to identify what was different in your run.

Other than that, I'd agree that Python tests take too long to run. This is because we run NextworkX to compare the result against it. It would be good to find a way to reduce the time of these tests.

@aschaffer
Copy link
Collaborator

Is this a regression? Tests "take very long" compared to what baseline? (we don't really have perf tests yet, afaik).

@seunghwak
Copy link
Contributor Author

Is this a regression? Tests "take very long" compared to what baseline? (we don't really have perf tests yet, afaik).

I assumed the purpose of this test is to really assure that all the parts are properly installed and working, and for this purpose, I think the test should finish in minutes or less. I will rerun the test to get exact timing but as I remember this took around 20-30 minutes... Users will think something is wrong if tests take this long.

@afender
Copy link
Member

afender commented Feb 19, 2019

There are really 2 different topics here :

  1. make python tests run faster : [BUG] Python tests take too long #83
  2. errors and warning in @seunghwak's tests

Both need to be addressed. I will create another task for (1) and let's keep track of (2) in this issue.

@afender afender added 1 - On Deck and removed ? - Needs Triage Need team to review and classify labels Feb 19, 2019
ChuckHastings pushed a commit to ChuckHastings/cugraph that referenced this issue Oct 26, 2020
[gpuCI] Auto-merge branch-0.16 to branch-0.17 [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants