Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bool column corruption with ORC Reader #7483

Merged
merged 4 commits into from
Mar 22, 2021
Merged

Fix bool column corruption with ORC Reader #7483

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dcbd8b1
changes
Mar 1, 2021
ed2f93c
Merge branch 'branch-0.19' of https://github.com/rapidsai/cudf into b…
rgsl888prabhu Mar 1, 2021
f392881
Merge branch 'branch-0.19' of https://github.com/rapidsai/cudf into b…
rgsl888prabhu Mar 2, 2021
03f0486
changes
rgsl888prabhu Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/io/orc/stripe_data.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1556,7 +1556,7 @@ __global__ void __launch_bounds__(block_size)
if (t == 0) { s->top.data.buffered_count = n; }
}

numvals = min(numvals * 8, is_last_set ? s->top.data.max_vals : blockDim.x);
numvals = min(numvals * 8, is_last_set ? (s->top.data.max_vals + 7) & (~0x7) : blockDim.x);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given how common this is, we should have a ceil to next byte function rather than have a +7)&~7 everywhere.


} else if (s->chunk.type_kind == LONG || s->chunk.type_kind == TIMESTAMP ||
s->chunk.type_kind == DECIMAL) {
Expand Down