Fix bool column corruption with ORC Reader #7483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ool_issue_with_reader
…ool_issue_with_reader
rgsl888prabhu
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7483 +/- ##
===============================================
+ Coverage 81.80% 82.26% +0.45%
===============================================
Files 101 101
Lines 16695 17244 +549
===============================================
+ Hits 13658 14185 +527
- Misses 3037 3059 +22
Continue to review full report at Codecov.
|
vuule
approved these changes
Mar 5, 2021
|
Looks like generating a test for the fix is more trouble than it's worth. Approving without the test. |
rgsl888prabhu
added
3 - Ready for Review
devavret
approved these changes
Mar 17, 2021
devavret
reviewed
Mar 17, 2021
| @@ -1556,7 +1556,7 @@ __global__ void __launch_bounds__(block_size) | |||
| if (t == 0) { s->top.data.buffered_count = n; } | |||
| } | |||
|
|
|||
| numvals = min(numvals * 8, is_last_set ? s->top.data.max_vals : blockDim.x); | |||
| numvals = min(numvals * 8, is_last_set ? (s->top.data.max_vals + 7) & (~0x7) : blockDim.x); | |||
There was a problem hiding this comment.
Given how common this is, we should have a ceil to next byte function rather than have a +7)&~7 everywhere.
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there was a possibility that only partial set of bits would be read in case the values are buffered, the max_vals had to be rounded-off to higher next byte.
closes #7345