Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing parquet benchmarks #7214

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Fixing parquet benchmarks #7214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6056d2
fix benchmarks
rgsl888prabhu Jan 26, 2021
41c7eff
review changes
rgsl888prabhu Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ void BM_parq_write_varying_inout(benchmark::State& state)

void BM_parq_write_varying_options(benchmark::State& state)
{
auto const compression = static_cast<cudf::io::compression_type>(state.range(0));
auto const enable_stats = static_cast<cudf::io::statistics_freq>(state.range(1));
auto const output_metadata = state.range(2) != 0;
auto const compression = static_cast<cudf::io::compression_type>(state.range(0));
auto const enable_stats = static_cast<cudf::io::statistics_freq>(state.range(1));
auto const file_path = state.range(2) != 0 ? "unused_path.parquet" : "";

auto const data_types = get_type_or_group({int32_t(type_group_id::INTEGRAL_SIGNED),
int32_t(type_group_id::FLOATING_POINT),
Expand All @@ -82,8 +82,7 @@ void BM_parq_write_varying_options(benchmark::State& state)
cudf_io::parquet_writer_options::builder(source_sink.make_sink_info(), view)
.compression(compression)
.stats_level(enable_stats)
.return_filemetadata(output_metadata)
.column_chunks_file_path("dummy_path.parquet");
.column_chunks_file_path(file_path);
cudf_io::write_parquet(options);
}

Expand Down