Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing parquet benchmarks #7214

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

rgsl888prabhu
Copy link
Contributor

return_filemetadata was removed in one of the recent PR, and missed to remove it in benchmarks.

@rgsl888prabhu rgsl888prabhu added bug Something isn't working 3 - Ready for Review Ready for review by team cuIO cuIO issue 4 - Needs cuIO Reviewer non-breaking Non-breaking change labels Jan 26, 2021
@rgsl888prabhu rgsl888prabhu self-assigned this Jan 26, 2021
@rgsl888prabhu rgsl888prabhu requested a review from a team as a code owner January 26, 2021 18:30
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #7214 (41c7eff) into branch-0.18 (8860baf) will increase coverage by 0.11%.
The diff coverage is 92.85%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7214      +/-   ##
===============================================
+ Coverage        82.09%   82.20%   +0.11%     
===============================================
  Files               97       98       +1     
  Lines            16474    16692     +218     
===============================================
+ Hits             13524    13722     +198     
- Misses            2950     2970      +20     
Impacted Files Coverage Δ
python/cudf/cudf/_lib/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 91.66% <ø> (-0.09%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.13% <ø> (-0.29%) ⬇️
python/cudf/cudf/core/column/string.py 86.65% <ø> (ø)
python/cudf/cudf/core/dataframe.py 90.49% <ø> (-0.22%) ⬇️
python/cudf/cudf/core/dtypes.py 89.94% <ø> (-0.45%) ⬇️
python/cudf/cudf/core/frame.py 90.10% <ø> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 93.59% <ø> (ø)
python/cudf/cudf/core/multiindex.py 82.19% <ø> (+0.05%) ⬆️
python/cudf/cudf/core/reshape.py 91.19% <ø> (+0.16%) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a4c760...41c7eff. Read the comment docs.

@harrism
Copy link
Member

harrism commented Jan 26, 2021

@gpuciboth merge

@harrism
Copy link
Member

harrism commented Jan 26, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d97b09e into rapidsai:branch-0.18 Jan 26, 2021
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuIO Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working cuIO cuIO issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants