Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #16045 to 24.06 #16102

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Backport #16045 to 24.06 #16102

merged 3 commits into from
Jul 1, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 26, 2024 •
edited by raydouglass
Loading

Description

Backporting #16045 for a patch release.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@pmattione-nvidia @vyasr
Add ast cast test (rapidsai#16045)
e7252cb 
Add test for AST cast-to-float64

Resolves rapidsai#16023

Authors:
  - Paul Mattione (https://github.com/pmattione-nvidia)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#16045
@vyasr vyasr added bug Something isn't working ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround non-breaking Non-breaking change labels Jun 26, 2024
@vyasr vyasr self-assigned this Jun 26, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 26, 2024
@vyasr vyasr changed the base branch from branch-24.08 to branch-24.06 June 26, 2024 17:08
@vyasr vyasr marked this pull request as ready for review June 26, 2024 17:09
@vyasr vyasr requested a review from a team as a code owner June 26, 2024 17:09
@vyasr vyasr requested review from harrism and davidwendt and removed request for a team June 26, 2024 17:09
@vyasr vyasr mentioned this pull request Jun 26, 2024
Merged
3 tasks
@davidwendt
Copy link
Contributor

Was there supposed to be a code fix here?
This looks like we are just backporting new unit test.

Perhaps this was for a cuco change. I'm not sure backporting a unit test is necessary. Are we concerned that possible future patches will break?

@vyasr
Copy link
Contributor Author

vyasr commented Jun 26, 2024

The fix is in #16101, you're right that this is just a test for that behavior. I'd be fine skipping the test and only backporting the actual fix. CC @bdice.

@bdice
Copy link
Contributor

bdice commented Jun 26, 2024

I favor backporting the test since it was missed in the original PR and provides a way to verify that the backported fix actually works in 24.06 (it was only tested in 24.08). I don’t have any specific concerns that it will fail, it is moreso a matter of completeness in addressing the reported bug in an easily verifiable way.

@raydouglass raydouglass merged commit 781794b into rapidsai:branch-24.06 Jul 1, 2024
70 of 71 checks passed
@vyasr vyasr deleted the hotfix/ast_decimal_cast_test branch July 1, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice bdice approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vyasr @davidwendt @bdice @raydouglass @pmattione-nvidia