Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ast cast test #16045

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Add ast cast test #16045

merged 3 commits into from
Jun 25, 2024

Conversation

pmattione-nvidia
Copy link
Contributor

@pmattione-nvidia pmattione-nvidia commented Jun 15, 2024 •
edited by vyasr
Loading

Add test for AST cast-to-float64

Resolves #16023

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@pmattione-nvidia pmattione-nvidia added libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 15, 2024
@pmattione-nvidia pmattione-nvidia requested a review from bdice June 15, 2024 16:33
@pmattione-nvidia pmattione-nvidia self-assigned this Jun 15, 2024
@pmattione-nvidia pmattione-nvidia requested a review from a team as a code owner June 15, 2024 16:33
@vyasr
Copy link
Contributor

vyasr commented Jun 24, 2024

@pmattione-nvidia FYI I added a closing note to the PR so that #16023 will be closed when this merges.

@bdice
Copy link
Contributor

bdice commented Jun 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit cdfb550 into rapidsai:branch-24.08 Jun 25, 2024
76 checks passed
vyasr pushed a commit to vyasr/cudf that referenced this pull request Jun 26, 2024
@pmattione-nvidia @vyasr
Add ast cast test (rapidsai#16045)
e7252cb 
Add test for AST cast-to-float64

Resolves rapidsai#16023

Authors:
  - Paul Mattione (https://github.com/pmattione-nvidia)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#16045
@vyasr vyasr mentioned this pull request Jun 26, 2024
Merged
3 tasks
@raydouglass raydouglass mentioned this pull request Jul 1, 2024
Merged
3 tasks
raydouglass pushed a commit that referenced this pull request Jul 1, 2024
@vyasr @pmattione-nvidia
Backport #16045 to 24.06 (#16102)
781794b 
Backporting #16045 for a patch release.

---------

Co-authored-by: Paul Mattione <156858817+pmattione-nvidia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- left review comments

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

@srinivasyadav18 srinivasyadav18 Awaiting requested review from srinivasyadav18 srinivasyadav18 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@pmattione-nvidia pmattione-nvidia

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
4 participants
@pmattione-nvidia @vyasr @bdice @wence-